Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement get all mentors public endpoint #90

Merged
merged 7 commits into from
Jan 14, 2024
Merged

implement get all mentors public endpoint #90

merged 7 commits into from
Jan 14, 2024

Conversation

janithlahirukariyawasam
Copy link
Member

@janithlahirukariyawasam janithlahirukariyawasam commented Jan 13, 2024 •
edited
Loading

Purpose

The purpose of this PR is to fix #14

Goals

The goal of this PR is to implement get all mentors public endpoint

Approach

Screenshots

image

image

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@janithlahirukariyawasam janithlahirukariyawasam marked this pull request as draft January 13, 2024 12:08
@janithlahirukariyawasam janithlahirukariyawasam marked this pull request as ready for review January 14, 2024 05:28
@janithlahirukariyawasam
Copy link
Member Author

janithlahirukariyawasam commented Jan 14, 2024 •
edited
Loading

@anjula-sack I think it is good to write unit test cases for the service layer instead of the routes.
and I think the reason for the test failure is we wrote unit test cases without mocking the repositories

@anjula-sack
Copy link
Member

@anjula-sack I think it is good to write unit test cases for the service layer instead of the routes. and I think the reason for the test failure is we wrote unit test cases without mocking the repositories

Can you create an issue for that? @janithlahirukariyawasam

anjula-sack
anjula-sack approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @janithlahirukariyawasam

@anjula-sack anjula-sack merged commit 31dc83c into sef-global:main Jan 14, 2024
1 check failed
anjula-sack pushed a commit to anjula-sack/scholarx-backend that referenced this pull request Jul 23, 2024
@Madhawa97
Add admin dashboard - manage mentor applications scene (sef-global#90)
2a4b257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjula-sack anjula-sack anjula-sack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Get all mentors endpoint (Public endpoint)
2 participants
@janithlahirukariyawasam @anjula-sack